Problem/Motivation

Coming from 3228147 I stumbled across other possible breaking changes in the future. It affects submodule simple_sitemap_engines and testing but I think it would be better to be consistent here.

Proposed resolution

  • Renaming corresponding files using PascalCase pattern → SimplesitemapEnginesForm will be SimpleSitemapEnginesForm
  • Fix annotations and comments.

Remaining tasks

  • Add a note to the release notes about possible breaking changes (see 3228147 for possible effects), so changes should be not part of a patch release.

Issue fork simple_sitemap-3377668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rwam created an issue. See original summary.

rwam opened merge request !73

rwam’s picture

rwam commented
Priority: Major » Normal
Status: Active » Needs review
walkingdexter’s picture

walkingdexter commented
Category: Bug report » Task

  • walkingdexter committed 3d1c311b on 4.x authored by rwam 
    Issue #3377668 by rwam, walkingdexter: Use PascalCase for class names
walkingdexter’s picture

walkingdexter commented
Status: Needs review » Fixed

Merged, thanks!

This is not a breaking change because PHP is case insensitive for the class names. However, in some environments, errors may occur due to file name changes. See #3228147: Class 'Drupal\simple_sitemap\Queue\SimpleSitemapQueue' not found for additional information. This should be described in the release notes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.