Replace static administration links with dynamic ones [#3364200]

Problem/Motivation

I have a project and I change the admin's path from /admin to /something if using this module some links give me /something and some
/admin and I have a 404.

Steps to reproduce

1- Change the admin path
2- enable the module and try all links get from the module.

Proposed resolution

1- Change all paths on the module to be dynamically linked using the Url class

Comment	File	Size	Author
#2	change-all-the-static-paths-3364200-2.patch	17.49 KB	abdulaziz zaid
#2	4.x: PHP 8.1 & MySQL 8, D9.5 32 pass

Issue fork simple_sitemap-3364200

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3364200-change-all-the changes, plain diff MR !69
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 June 2023 at 14:00

abdulaziz zaid created an issue. See original summary.

Comment #2

abdulaziz zaid

Arabic

Riyadh

CreditAttribution: abdulaziz zaid at NELC for NELC commented 1 June 2023 at 14:27

File	Size
change-all-the-static-paths-3364200-2.patch	17.49 KB
4.x: PHP 8.1 & MySQL 8, D9.5 32 pass

Comment #3

abdulaziz zaid

Arabic

Riyadh

CreditAttribution: abdulaziz zaid at NELC for NELC commented 1 June 2023 at 14:34

Status:

Active

» Needs review

Comment #4

gbyte CreditAttribution: gbyte at gbyte commented 1 June 2023 at 16:09

Status:

Needs review

» Needs work

That's fair enough! Mind creating an MR for this instead of a patch? Thanks.

Comment #5

1 June 2023 at 18:28

shivam_tiwari made their first commit to this issue’s fork.

Comment #6

1 June 2023 at 18:36

shivam_tiwari opened merge request !69

Comment #7

shivam_tiwari CreditAttribution: shivam_tiwari at Innoraft commented 1 June 2023 at 18:44

Status:

Needs work

» Needs review

Comment #8

2 June 2023 at 12:18

gbyte committed daf0c5ab on 4.x

Issue #3364200 by shivam_tiwari, abdulaziz zaid, gbyte: change all the...

Comment #9

gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented 2 June 2023 at 12:21

Status:

Needs review

» Fixed

We don't need $GLOBALS['base_url'] with the URL object. I decided to make the URLs relative apart from the ones that get written into the log file. I also removed all the redundant $url variables. Thanks for looking into it.