Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Location admin/config/search/simplesitemap/engines
Referrer admin/config/search/simplesitemap
Drupal 8.9.6
Php 7.3
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | simple_sitemap-fix-notice-undefined-index-attributes-3173530-6.patch | 931 bytes | dwebpoint |
Comments
Comment #2
dwebpoint CreditAttribution: dwebpoint at EPAM Systems commentedFieldsets can only be used in forms, while details elements can be used outside of forms.
So, I'd suggest to change element type from "fieldset" to "details"
Comment #3
dwebpoint CreditAttribution: dwebpoint at EPAM Systems commentedModified patch to pass through Patch Apply stage
Comment #4
dwebpoint CreditAttribution: dwebpoint at EPAM Systems commentedComment #5
dwebpoint CreditAttribution: dwebpoint at EPAM Systems commentedComment #6
dwebpoint CreditAttribution: dwebpoint at EPAM Systems commentedModified patch to pass through Patch Apply stage one more time
Comment #7
DeSci CreditAttribution: DeSci commented@dwebpoint #6 fixed
Thanks.
Comment #8
DeSci CreditAttribution: DeSci commentedComment #9
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented@DeSci Creating a patch does not fix the issue. It needs to be tested, accepted and merged first. Also please open up bug reports against the dev version of the module in the future, as the fix may already have been merged to dev.
Comment #10
ysamoylenko CreditAttribution: ysamoylenko at EPAM Systems commentedHello @dwebpoint,
#6 looks good for me.
Replacement of the "fieldset" with "details" fixes the issue.
Happy to RTBC!
Testing environment:
PHP 7.3, D8.8.6, 8.x-3.x module branch
@gbyte, Please commit the changes.
Comment #12
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedThat's new. Thanks guys!