The Logger file uses dependency injection to inject the Messenger service. To properly support dependency injection, it should typehint using the MessengerInterface. It currently typehints with Core's Messenger service directly, which breaks things if any other module were to swap the Messenger service with their own.

CommentFileSizeAuthor
#2 simple_sitemap-support_swapping_messenger-3102084-2.patch1.08 KBashrafabed

Comments

ashrafabed created an issue. See original summary.

ashrafabed’s picture

ashrafabed
he
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new simple_sitemap-support_swapping_messenger-3102084-2.patch1.08 KB

Patch is attached. This is fairly straightforward, merging it won't impact anything negatively.

  • gbyte.co committed 27a6876 on 8.x-3.x 
    Issue #3102084 by gbyte.co, ashrafabed: Incompatible with modules that...
gbyte’s picture

gbyte
Location Berlin
commented
Assigned: ashrafabed » Unassigned
Category: Bug report » Task
Status: Needs review » Fixed

Done, thanks for the patch! Not a bug tough.

ashrafabed’s picture

ashrafabed
he
Primary language English
commented

Was marked as a bug because when a different module which overrode the messenger service was installed, simple_sitemap took my site down. Thanks for merging it so quickly!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.