After running cron on task Simple XML Sitemap (Search engines), logs listed submitting the variant path I'd created, even before linking it to any content.

Logs also showed that /default/sitemap.xml had been submitted. I'm not certain why - but default/sitemap.xml was showing up as blank page until I created another variant (prior to clearing cache that path was a 404 so I don't think this was caching issue). Maybe can reproduce on fresh install.

Maybe need a feature to check if links yet exist before submission - and somehow notify problem in log?

Also it might make more sense if Status page linked directly to the variant that db logs report has been submitted for default: /default/sitemap.xml. Currently that 'published on [date]' links directly to root at /sitemap.xml - which again, in my tests I saw a difference between /sitemap.xml (loaded links) and /default/sitemap.xml (loaded blank until another variant was added).

Thanks for this increasingly powerful module - becoming more robust to point it should be renamed to sitemap_power perhaps.

Comments

vrwired created an issue. See original summary.

gbyte’s picture

Title: logs reporting submitted before generated/linked variant » Prevent submitting empty/unaccessible variants

Logs also showed that /default/sitemap.xml had been submitted. I'm not certain why - but default/sitemap.xml was showing up as blank page until I created another variant (prior to clearing cache that path was a 404 so I don't think this was caching issue). Maybe can reproduce on fresh install.

This would be a different issue. Please try to reproduce it in the dev version and if you succeed please open up a bug report documenting how you did it. I couldn't reproduce.

Also it might make more sense if Status page linked directly to the variant that db logs report has been submitted for default: /default/sitemap.xml. Currently that 'published on [date]' links directly to root at /sitemap.xml - which again, in my tests I saw a difference between /sitemap.xml (loaded links) and /default/sitemap.xml (loaded blank until another variant was added).

As I explaind in the other issue, I believe you simply did not have the variant named 'default' set as default. Only the default variant is accessible under /sitemap.xml, all others are accessible under variant-name/sitemap.xml. The link under status should match the report in logs and for the default variant the shorter URL should be displayed (/sitemap.xml).

If you find this is a bug, please, as above, test dev and document a way to reproduce this in a new bug report.

Thanks for this increasingly powerful module - becoming more robust to point it should be renamed to sitemap_power perhaps.

Don't make me blush. :)

  • gbyte.co committed e97347f on 8.x-3.x
    Issue #3094829 by vrwired, gbyte.co: Prevent submitting empty/...
gbyte’s picture

Status: Active » Fixed
Issue tags: +Needs tests

This is now implemented in 3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.