Provide more granular permissions

I have tested the patch in comment #2 running Drupal 8.7.6

I can confirm that the patch works on Drupal 8.8 wit simple_sitemap 8.3.5

That's a basic support that works but it would be great to set permission per enabled entity type and bundle.

+++ b/simple_sitemap.permissions.yml
@@ -2,3 +2,8 @@ administer sitemap settings:
+administer individual sitemap settings:
+  title: 'Administer individual sitemap settings'

This machinename feels a bit off for me. Because when committed its difficult to change, I would prefer to improve this in the issue here.

In other content-management/edit permissions words like "any", "content"/"nodes" and "override" are used.

@seanB came up with administer entity sitemap settings

+++ b/src/Form/FormHelper.php
@@ -194,7 +194,11 @@ class FormHelper {
+    if ($this->getEntityTypeId() === NULL && !$this->currentUser->hasPermission('administer sitemap settings')) {
+      return FALSE;
+    }
+
+    elseif ($this->getEntityTypeId() !== NULL && !$this->currentUser->hasPermission('administer individual sitemap settings')) {

Is this correct? Does this work with either one of the permissions, or does a user needs both permissions. (i will doublecheck manually).

#5
That's a basic support that works but it would be great to set permission per enabled entity type and bundle.

@5 That would be great, but I am fine with doing more granular permission in a follow-up.
Then this issue could only be

provide permission for editing individual settings for entities.

Changed the new permission name to edit entity sitemap settings
And fixed a logic error where one could not access the edit-form without the new permission.
Permissions behavior in new patch:
- When on entity-edit form; one must have either 'Administer sitemap settings' or 'Edit entity sitemap settings'
- Otherwise one must have 'Administer sitemap settings'

It's 30 degrees here in Amsterdam and the if-then-conditionals made my mind spin

+++ b/src/Form/FormHelper.php
@@ -205,7 +205,11 @@ class FormHelper {
+    elseif ($this->getEntityTypeId() !== NULL && (!$this->currentUser->hasPermission('edit entity sitemap settings') && !$this->currentUser->hasPermission('administer sitemap settings'))) {

This is kind of hard to read. Maybe we should put things in variables?

$is_entity = $this->getEntityTypeId() === NULL;
$is_admin = $this->currentUser->hasPermission('administer sitemap settings');
$can_edit_entity = $this->currentUser->hasPermission('edit entity sitemap settings');

I can apply the patch from the MR on 4.1.1 nicely and it seems to do what is desired. But in 4.1.2, the patch no longer applies.

Should work with 4.1.2 now.

deleted

Made a patch for the same issue before we found out that this issue already existed.

Patch #20-2 is not built on #11, and also it will not enable the option to regenerate the sitemap when saving a node if you are not administrator.

Patch #20-2 is from current -dev branch, seems #11 wont apply anymore.

Patch-file of #19, because .diff can change if more changes are pushed to the mr.

Thanks everyone for the work on this important change to this module. I tested the patch from #24 and it worked for me, on PHP 8.1 / Drupal 9.5.8 / simple_sitemap 4.1.4. Looks good to me. This was marked 'needs work' but it doesn't look like it needs work. I changed it to 'Needs review' but if I am wrong please feel free to set it back to 'needs work'. RTBC in my book.

Note that the patch will cause fatal errors with the simple_sitemap_engines module, since Drupal\simple_sitemap_engines\Form\FormHelper extends Drupal\simple_sitemap\Form\FormHelper.

Fatal error: Declaration of Drupal\simple_sitemap_engines\Form\FormHelper::formAlterAccess(): bool must be compatible with Drupal\simple_sitemap\Form\FormHelper::formAlterAccess(Drupal\Core\Entity\EntityFormInterface $form_object): bool in /app/web/modules/contrib/simple_sitemap/modules/simple_sitemap_engines/src/Form/FormHelper.php on line 63

I couldn't apply the MR 38 patch to I checked out the branch locally and merged 4.2.1 and made a diff.

This patch should work for 4.2.1

Simplified and committed, thanks! Thoughts from #21 are respected. Credits saved for the guys from #3441488: New permission to only edit entity sitemap settings .