CommentFileSizeAuthor
#3 simple_sitemap-convert_tests-2938243-3.patch37.44 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Issue tags: +PHPUnit
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new simple_sitemap-convert_tests-2938243-3.patch37.44 KB

And here a patch.

Thanks for the review.

gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Needs work

Thanks for your work!

Getting this when running run-tets.sh with --module simple_sitemap

Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest 0 passes 1 exceptions
FATAL Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest: test runner returned a non-zero error code (2).
Drupal\Tests\simple_sitemap\Functional\SimplesitemapTest 0 passes 1 fails

Am I missing something?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hello,

Strange. The tests on my local environment and on testbot passed.

I am using this config of phpunit: https://github.com/FlorentTorregrosa/docker-drupal-project/blob/8.x/scri...

and I run the tests using the command:

sudo -u $WEBSERVER_USER -E $PROJECT_PATH/vendor/bin/phpunit -c $PROJECT_PATH/scripts/tests/phpunit.xml --group simple_sitemap

in https://github.com/FlorentTorregrosa/docker-drupal-project/blob/8.x/scri...

"run-tests-phpunit.sh --group simple_sitemap"

gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs work » Fixed

It was my local configuration. Thanks for contributing!

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Thanks for the commit.

Now I can work on #2887373: Override a non-indexed bundle on a per-entity basis

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gbyte’s picture

gbyte
Location Berlin
commented