Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The chnagereq element in the site map is still outstanding.
Comment | File | Size | Author |
---|---|---|---|
#16 | adding-changefreq-2875538-16.patch | 23.22 KB | rli |
| |||
#10 | adding-changefreq-2875538-comment-12069822-10.patch | 22.04 KB | rli |
| |||
#7 | adding-changefreq-2875538-comment-12069822-0.patch | 8.39 KB | vytch |
| |||
#5 | 2875538-5.patch | 19.94 KB | nikunjkotecha |
| |||
#4 | adding-changefreq-2875538-comment-12069822.patch | 8.38 KB | vytch |
Comments
Comment #2
vytch CreditAttribution: vytch commentedComment #3
vytch CreditAttribution: vytch at Deloitte Digital commentedComment #4
vytch CreditAttribution: vytch at Deloitte Digital commentedFixing the notice message when the changefreq is not yet defined
Comment #5
nikunjkotechaAdding patch with all required changes to add changefreq element.
Comment #6
vytch CreditAttribution: vytch at Deloitte Digital commentedIf a node has been already treated as a menu_link_content, then it does not get the data set from the node edit page.
Comment #7
vytch CreditAttribution: vytch at Deloitte Digital commentedFixing issue with notice error.
Comment #8
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedThanks for your input guys. @vytch Can you incorporate your change into #5? It seems that one is more complete. I am going to review it in a few moments.
Comment #9
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commented@nikunjkotecha thanks for yout patch. I have found a couple of issues that need fixing before we commit.
simple_sitemap_entity_overrides
and configuration storage ofsimple_sitemap.bundle_settings.* and simple_sitemap.custom
.Notice: Undefined index: changefreq in Drupal\simple_sitemap\Simplesitemap->setEntityInstanceSettings() (line 418 of Simplesitemap.php).
when trying to override entity instance.Custom links
after applying the patch, the paths are formatted incorrectly in the textbox. There must be an (optional) way of adding changefreq for custom links and the value added needs to be validated.+ ? $custom_link['path'] . ' ' . $this->formHelper->formatPriority($custom_link['changefreq'])
. There should be a formatChangefreq function I believe.Another question is, what do you think about implementing automatic changefreq values for entities (as we have last viewed and created data) as xmlsitemap does?
Thanks!
Comment #10
rliAccording to the comment in #9, re-rolled the patch in #5 to fix following:
simple_sitemap_entity_overrides
to fix the PHP warnings. The config storage is already changed in the patch in #5.Notice: Undefined index: changefreq in Drupal\simple_sitemap\Simplesitemap->setEntityInstanceSettings() (line 418 of Simplesitemap.php).
is gone after altered the db.Have not got time to think about the automatic changefreq generation yet. The options allows user to control the value per content type is good enough for our project at the moment.
Comment #11
rliComment #14
rliSeems no need to add column in db as the settings are stored as serialised array.
Comment #15
rliAdded update hook to alter all existing data.
Comment #16
rliRerolled patch to alter all existing settings.
Comment #18
gbyte CreditAttribution: gbyte as a volunteer and at gbyte commentedThanks for your patches guys, couldn't use them much however. I've committed all changes to dev, please take a look for me.