Problem/Motivation

I think it makes sense for this to be a service. It makes it easier to test/instantiate/inject and override.

Proposed resolution

Convert it to a service.

Remaining tasks

Write a patch.

User interface changes

None.

API changes

Alterations in the signature for the Simplesitemap class.

Data model changes

None.

CommentFileSizeAuthor
#4 2684757-sitemap-generator-service-4.patch8.75 KBsam152
#2 2684757-sitemap-generator-service-2.patch8.27 KBsam152

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
StatusFileSize
new 2684757-sitemap-generator-service-2.patch8.27 KB

Attached is a first pass. Now that the generator can be injected into controllers and forms, there is probably some follow-up work that can be done with this, but will leave the changes as fairly minimal for now.

sam152’s picture

sam152 commented
Status: Active » Needs review
sam152’s picture

sam152 commented
StatusFileSize
new 2684757-sitemap-generator-service-4.patch8.75 KB

Here is one that actually applies to HEAD.

gbyte’s picture

gbyte
Location Berlin
commented
Status: Needs review » Fixed

I was planning on going there, glad you made the first step. I had to alter the patch slightly to avoid php errors. I'm going to mark this as fixed, but it would be great if you could follow up on #2 as soon as you have any ideas.

Thanks for your contribution!

sam152’s picture

sam152 commented

Not a problem at all. I'll open the relevant issues.

  • gbyte.co committed d6600e4 on 8.x-2.x authored by Sam152 
    Issue #2684757 by Sam152: Convert Simplesitemap class into a service

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.