There probably ought to be a hook_requirements check for curl, or at least a log entry if curl_init fails. This is especially important because the curl calls happen in simple_paypal_ipn_verify, which is hard to debug since it's normally called when you get an IPN from PayPal.

CommentFileSizeAuthor
#4 simple_paypal.install.txt1.05 KBksenzee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Version: 5.x-1.1 » 5.x-1.x-dev

Certainly a good idea.

hook_requirements() seem the best way to go.

Can you contribute a patch?

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Title: will silently fail if curl isn't enabled » Add hook_requirements() for curl instead of failing silently when transactions are done ...
Status: Active » Needs work
ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
Assigned: Unassigned » ksenzee

Sure, when I get a minute.

ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented
FileSize
simple_paypal.install.txt1.05 KB

I'm attaching a new .install file for the module with simple_paypal_requirements function (just remove the .txt extension). Sorry it's not a patch -- I'm not sure how to cvs diff a new file on a read-only repo.

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Status: Needs work » Needs review

thank you for the patch.

I included it in the dev version, and it should be present in tomorrow's tarball.

If it gets sufficient testing, I will create a stable version.