There are some coding standard issues in this module code.

CommentFileSizeAuthor
#4 2879994-coding-standard-4.patch5.21 KBdeepanker_bhalla
#2 simple_mobile_login.patch3.53 KBjayesh_makwana
simple_mobile_login.txt956 bytesjayesh_makwana

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana commented
StatusFileSize
new simple_mobile_login.patch3.53 KB

We create patch for solving coding standard issues. Please check and apply it.

deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Active » Reviewed & tested by the community
deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2879994-coding-standard-4.patch5.21 KB

Your patch is not being able to apply.

Thus kindly check the updated patch with the fix.

Note: Sorry for the previous status as it was by mistake.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

I can confirm the patch #4 applies cleanly and fixes all the coding standard. Here is the output.

$git apply -v 2879994-coding-standard-4.patch
Checking patch simple_mobile_login.module...
Applied patch simple_mobile_login.module cleanly.

$phpcs --standard=Drupal .

No coding standard warning reported by the PHPCS after applying patch #4.