Hello,

When editing the View that Similar Entries provides, and clicking into the Theming Information screen, you can see that the module shows all of the template suggestion names with a space in the filename.

For example, "views-view--Similar Entries.tpl.php" or "views-view-fields--Similar Entries--block.tpl.php"

(See attached screenshot)

To avoid problems due to spaces in filenames, and to conform to standards, the space should be replaced with a hyphen, and the text should also probably be converted to lower case.

Like, "views-view--similar-entries.tpl.php" or "views-view-fields--similar-entries--block.tpl.php"

-Dave

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

Version: 7.x-2.0-beta5 » 7.x-2.x-dev
Issue summary: View changes
Status: Active » Needs review
FileSize
4.04 KB

This is definitely still an issue. It stems from the fact that the machine name for the view is "$view->name = 'Similar Entries';" which contains both uppercase letters and a space. I think we should change the machine name to "similar_entries".

We are going to need to also provide an update hook, since we can't go changing people's default views out from under them. This could be tricky as not only do we need to update any overridden views, but if the block has been placed into a region, we will also need to update the delta in the block table.