Problem/Motivation

The project seems to have Functional Automated tests already see:
https://git.drupalcode.org/project/shs/-/tree/2.0.x/tests/src/Functional...

But they don't seem to be currently integrated with the new GitLab CI Automated testing infrastructure.

Steps to reproduce

Browse to project's repository Build Pipelines: https://git.drupalcode.org/project/shs/-/pipelines

Proposed resolution

Transition the project to use GitLab CI pipelines instead of DrupalCI, to provide similar automated testing conditions: PHP, DB, Core versions, branches, triggers on commits, merge requests, patches submitted in tickets, etc...

As described in the Documentation on Drupal.org: GitLab CI, with corresponding config template file:
https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...

Remaining tasks

There might be additional validation Build errors or warnings with the merge requests, when the tests run for the first time, for example, phpstan, phpcs, cspell, etc...
We will probably need to figure out whether they should be fixed in the same ticket or specific ones.
 

Feel free to let us know if you have any suggestions, comments, or feedback on this ticket or the project in general, we would be glad to help and provide more information.
Thanks in advance!

Issue fork shs-3433198

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DYdave created an issue. See original summary.

DYdave opened merge request !29

Liam Morland made their first commit to this issue’s fork.

dydave’s picture

dydave commented
Priority: Normal » Major
Status: Active » Needs review

Hi Joseph (@joseph.olstad),

Could you please help us take a look at this MR when you have some time ?

I've paid particular attention not to modify anything that could break Backward Compatibility (BC), such as translated strings or class names.

At this point, MR!29 seems to be passing all jobs except ESLint and PHPStan which are probably more complicated and would most likely require specific issues to fix :
MR!29 Pipeline: https://git.drupalcode.org/issue/shs-3433198/-/pipelines/264680

Moving issue to Needs review and bumping to Major as an attempt to attract maintainers attention.

Getting module's GitLab CI configuration added to the repository would allow getting all pending merge requests automatically tested.

Feel free to let us know if you have any questions or concerns on any of the changes in the merge request or this ticket in general, we would surely be glad to help.
Thanks in advance!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

phpcs is failing, please turn phpcs OFF

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Related issues: +#3463894: Update templates so 11.0 is the default/current branch, +#3481309: Stop changing the meaning of tests

phpcs issues fixed.

phpunit tests were failing due to #3463894: Update templates so 11.0 is the default/current branch. I fixed this by pinning the version of the testing template as recommended in #3481309: Stop changing the meaning of tests.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Reviewed & tested by the community

Looking great, also nice to see the coding standards check pass!

  • joseph.olstad committed 2c561733 on 2.0.x authored by dydave 
    Issue #3433198 by DYdave: Automated testing on GitLab CI: Added initial...
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Reviewed & tested by the community » Fixed
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Fixed » Patch (to be ported)

Needs to be ported to the 3.x branch.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

did a partial cherry pick of the work from 2.0.x into 3.0.x . Not sure if this will work as expected.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Patch (to be ported) » Fixed

Good enough for now, if you want to push this further , open a new issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.