Issue fork shs-3269746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

System Lord created an issue. See original summary.

tasc’s picture

tasc
Primary language German
Location Berlin
commented

I just found this issue as well.
On WidgetView.js in line 125 I changed:
widget.$el.append => widget.$el.prepend

plain diff Patch #4

tasc opened merge request !4

System Lord’s picture

System Lord commented

Perfect! It works! Thank you for the diff as well!

Note: I had to clear cache a couples time and close and reopen my browser to get it all cleared out.

System Lord’s picture

System Lord commented
Status: Active » Needs review
iancawthorne’s picture

iancawthorne commented

I spotted the same problem and this patch fixes it for me.

hmendes’s picture

hmendes commented
Version: 2.0.0-rc3 » 2.0.x-dev
Status: Needs review » Reviewed & tested by the community

Changing to the dev branch and changing the status to RTBC as I can also confirm that this solved the problem.

khaldoon_masud’s picture

khaldoon_masud commented

+1

saganakat’s picture

saganakat commented
Issue summary: View changes

Thanks! This patch fixes it for me.

dydave’s picture

dydave commented
Issue summary: View changes

Hi everyone,

Thank you very much for raising this issue and providing a patch, it's greatly appreciated.

I would like to confirm as well, testing successfully the patch with the following versions:

  • shs: '2.0.0-rc4'
  • core: '9.5.10'

 
The patch applied cleanly with composer and appears to have fixed the issue, with the label "- Select a value -" back at the top of the select list.
 
It would be great if a maintainer of the project could take a quick look at the patch and let us know if there would be any more work needed.
 
In any case, thanks again very much to everyone for your help with this issue.

rossb89’s picture

rossb89 commented

Yup this patch works great, lets get it merged.

anish.a’s picture

anish.a commented

This can be merged. Tested and working fine

socialnicheguru’s picture

socialnicheguru commented

does not apply to shs 3@beta3
It was RTBC but just needs a reroll

socialnicheguru’s picture

socialnicheguru commented
Status: Reviewed & tested by the community » Needs work
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Keep 2x and 3x seperate

make a new MR for 3x

  • joseph.olstad committed 52a551ed on 2.0.x 
    Issue #3269746 by tasc, dydave, socialnicheguru, hmendes, iancawthorne,...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Fixed

3.0.x is NOT affected, already has the fix.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/shs/releases/2.0.2

dydave’s picture

dydave commented

Thanks a lot Joseph (@joseph.olstad) for getting this in and creating and new release!
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.