Problem/Motivation

While going through the theme for issues I found out that the Twitter logo is still the old one.

Steps to reproduce

Install the theme and check for the Twitter logo

Proposed resolution

The icon needs to be updated with the new Twitter logo X

Remaining tasks

none

User interface changes

yes

API changes

none

Data model changes

none

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Hamid.ali created an issue. See original summary.

sourojeetpaul’s picture

Assigned: Unassigned » sourojeetpaul

Working on it!

sourojeetpaul’s picture

StatusFileSize
new17.42 KB
sourojeetpaul’s picture

Assigned: sourojeetpaul » Unassigned
Status: Active » Needs review

Hello @Hamid.ali,

I tried to reproduce the issue by installing the theme and setting that as default theme of the site, but I found that there's no such social icons section present in the theme intrinsically. I think the screenshot which you attached along the issue is from the demo site of the theme, where the social icons are present in a block "Connect with Us". Also as there are no such block available readily, I think that this block on the demo site is a custom block, which uses fontawesome icons for the icons.
In that case, I tried to replicate the custom block on my own, and observed that the issue is arising due to an older version of fontawesome CDN referenced in the libraries.yml. To mitigate that issue, I've changed the CDN reference to the latest version where the x-twitter logo is available and also raised an MR for the same. Pls have a look:
https://git.drupalcode.org/project/showcase_lite/-/merge_requests/9

After making these changes the social icons are showing properly with the updated twitter logo on my block, like this:
Social Icons

nupur badola’s picture

Status: Needs review » Needs work

No section is present for social share icons. Please review.

sourojeetpaul’s picture

Status: Needs work » Needs review

@Nupur Badola, I've mentioned the same on my last comment #5
The social icons section was made by placing a custom block. Please go through my findings once again!

hamid.ali’s picture

@sourojeetpaul i replicated the demo site design with the custom block for the social icons. My main aim was to showcase the twitter icon has to be updated which is as u mentioned by updating the lib version

sourojeetpaul’s picture

@Hamid.ali, Can you please confirm whether the issue gets resolved by the patch provide by me here!
MR !9

ashutosh ahirwal’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice, +CSS
StatusFileSize
new21.38 KB

I have reviewed MR9 and if we use then this will resolve this issue
I have created my own custom block from demo site.
moving to RTBC