mobile menu issue

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 Screenshot (12).png13.15 KBnupur badola
#7 showcase-after-patch.png13.53 KBbindu r
#7 showcase-before-patch.png18.74 KBbindu r
#5 issue_when_closing_the_menu.png12.78 KBtanuja bohra
#3 after2-patch.png88.09 KBlokeshsahu
#3 after1-patch.png47.34 KBlokeshsahu
#3 before-patch.png125.86 KBlokeshsahu
#3 3329944-2.patch4.16 KBlokeshsahu
Screenshot 2022-12-28 at 3.31.38 PM.png39.91 KBalok_singh

Issue fork showcase_lite-3329944

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alokaman created an issue. See original summary.

lokeshsahu made their first commit to this issue’s fork.

lokeshsahu’s picture

lokeshsahu commented
StatusFileSize
new 3329944-2.patch4.16 KB
new before-patch.png125.86 KB
new after1-patch.png47.34 KB
new after2-patch.png88.09 KB

I have created a patch to address the above issue. I am attaching a screenshot for reference, showing the state before and after applying the patch.

lokeshsahu’s picture

lokeshsahu commented
Status: Active » Needs review
tanuja bohra’s picture

tanuja bohra commented
Assigned: alok_singh » Unassigned
Status: Needs review » Needs work
Issue tags: -On Mobile view, -Menu is not working and its not a mobile view style. wrong styling.
StatusFileSize
new issue_when_closing_the_menu.png12.78 KB

@lokeshsahu , I verified the #3 patch and the patch is working but the only issue I can see when we are closing the menu it's showing an old menu style.
Added screenshot for reference.

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs work » Needs review

Hello there,
First of all the issue summary is not very much clear, I guess we are talking about the main menu only in this regard. If so, I think this is a duplicate issue, Issue #3314868 already exist for the same.
https://www.drupal.org/project/showcase_lite/issues/3314868

The patch provided on this ticket seems to be targeting menu class generally which will affect all the menu including but not limited to only main-navigation menu. Also I've checked that the issue still persist on the latest version of the theme which is compatible with D10. So I've addressed the issue on that ticket and raised an MR by incorporating the concepts of Drupal Behaviour and Once function. Please have a look:
https://git.drupalcode.org/project/showcase_lite/-/merge_requests/10

The issue is resolved now and incorporated a hamburger menu with a panel slider for the main menu on tablet and mobile devices.
This is how it looks now on responsive screens
Hamburger Menu
Panel Slider

bindu r’s picture

bindu r commented
StatusFileSize
new showcase-before-patch.png18.74 KB
new showcase-after-patch.png13.53 KB

Hi , reviewed the MR 10, Applied cleanly and also the menu looks fine. Might look better if the top white space is reduced.

sourojeetpaul’s picture

sourojeetpaul commented

Hello, @bindu r,
The hamburger menu will open up as a panel and the actual menu items are vertically center aligned with respect to the panel, so if we reduce the space from the top, it'll look asymmetrical.

nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot (12).png13.15 KB

Still getting the same issue.