Currently, the st_spans are rendered inside the sharethis.manager service.

This could be moved further up the rendering chain, allowing the theming layer to take control over the rendering, and anything else in between to have better access to modifying the content.

CommentFileSizeAuthor
#11 avoid-rendering-spans-directly-in-the-service-2929460-11.patch3.69 KBmrinalini9
#4 2929460-avoid-rendering-spans-directly-in-the-service-3.patch3.53 KBLeon Kessler
#2 2929460-avoid-rendering-spans-directly-in-the-service-2.patch3.52 KBLeon Kessler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Leon Kessler created an issue. See original summary.

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Status: Active » Needs review
Parent issue: » #2903451: Twig template instead of theme function
FileSize
2929460-avoid-rendering-spans-directly-in-the-service-2.patch3.52 KB

In order to do this properly, we should be rendering using twig (rather than a theme function).

The following patch depends on the patch from the parent ticket.

Status: Needs review » Needs work

The last submitted patch, 2: 2929460-avoid-rendering-spans-directly-in-the-service-2.patch, failed testing. View results

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
FileSize
2929460-avoid-rendering-spans-directly-in-the-service-3.patch3.53 KB

Adding new patch that applies with latest from parent ticket.

prafullsranjan’s picture

prafullsranjan CreditAttribution: prafullsranjan at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2929460-avoid-rendering-spans-directly-in-the-service-3.patch, failed testing. View results

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented

@prafullsranjan parent issue will need to be merged first. Patch from this ticket will keep failing as it depends on the parent patch.

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented
Status: Needs work » Needs review

Setting back to needs review now that parent ticket has made it in.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Novice
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
FileSize
avoid-rendering-spans-directly-in-the-service-2929460-11.patch3.69 KB

Rerolled patch #4 for 8.x-2.x, please review.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs review » Fixed
Issue tags: -Needs reroll

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.