Out of the box it doesn't seem to be possible to verify Drupal sites using this module with https://platform.sharethis.com.

The most obvious solution seems to be including this chunk of code:

<script type='text/javascript' src='//platform-api.sharethis.com/js/sharethis.js#property=<property key>&product=unknown' async='async'></script>

I'll attach a patch to configure a property key and add this script if it's set shortly. I'm not sure if there might be some better way to handle this though - e.g. through scripts included by the module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dylan Donkersgoed created an issue. See original summary.

Dylan Donkersgoed’s picture

Status: Active » Needs review
FileSize
5.42 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: allow_verifying_site-2919085-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Dylan Donkersgoed’s picture

Status: Needs work » Needs review
FileSize
7.07 KB
1.71 KB

Attached a new patch that fixed an error in the tests and added the new library to a couple places I missed before.

naveenvalecha’s picture

Status: Needs review » Needs work
Issue tags: +Needs upgrade path
+++ b/config/install/sharethis.settings.yml
@@ -11,6 +11,7 @@ option_extras:
+property_key: ''

need upgrade path for this new config