sharethis_update_7002 was added in #2759221: Unable to select services on the configuration page to clean up the sharethis_service_option variable. After updating to 7.x-2.x-dev, the services were still broken for me. I took a look at value of sharethis_service_option prior to update hook running at it looked like this:

"Facebook:facebook
","Twitter:twitter","Email:email"

Here is a patch that will also strip out amp; to fully make the changes in #2759221: Unable to select services on the configuration page work for all. Special thanks to @navneet0693 for helping me understand this on IRC.

CommentFileSizeAuthor
#3 remove_amp_in-2846432-3.patch1.13 KBvinmassaro
#2 remove_amp_in-2846432-2.patch913 bytesvinmassaro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vinmassaro created an issue. See original summary.

vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented
Status: Active » Needs review
FileSize
remove_amp_in-2846432-2.patch913 bytes
vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented
FileSize
remove_amp_in-2846432-3.patch1.13 KB

New patch to get the variable once, set the variable once.

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented 
+++ b/sharethis.install
@@ -83,6 +83,9 @@ function sharethis_update_7001() {
+  $sharethis_service_option = str_replace('amp;', '', $sharethis_service_option);

I am not sure, but only one service will get affected that is AT&T by this, which is saved like this "AT&T:att". I cannot see much differences, AT&T still appears :) Good to go, thanks for the patch!

navneet0693’s picture

navneet0693 CreditAttribution: navneet0693 as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community

purushotam.rai’s picture

purushotam.rai CreditAttribution: purushotam.rai at QED42 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.