The SessionLimit service class calls out to the config service like this

\Drupal::config('session_limit.settings')

This is static so needs to be injected instead.

CommentFileSizeAuthor
#2 session_limit_dependency_injection_2674242_2.patch6.08 KBnkoporec
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ceng created an issue. See original summary.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer and at Agiledrop - Your Trusted Drupal Teammates commented
Status: Active » Needs review
FileSize
session_limit_dependency_injection_2674242_2.patch6.08 KB

Created a patch with dependency injection for all services used.Please reviewed it.

johnennew’s picture

johnennew CreditAttribution: johnennew at Deeson commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

  • johnennew committed 191fe21 on 8.x-1.x authored by nkoporec 
    Issue #2674242 by nkoporec: Remove static calls to the config service...
johnennew’s picture

johnennew CreditAttribution: johnennew at Deeson commented
Status: Reviewed & tested by the community » Fixed

Marked as fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.