Right now users can be freaked out by the error level severity of the logged out message making them think they have done something wrong or their account has been compromised. You are able to change the message through string override but you cannot change the message severity. This patch ads that functionality.
Logout message admin
New message status

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

haydeniv’s picture

Status: Active » Needs review
FileSize
1.97 KB

And the patch.

johnennew’s picture

Status: Needs review » Active

@haydeniv, thanks for the patch! Not sure why the testbot has ignored it.

I was wondering if we should just go provide the ability to set the message in the admin screen for session_limit rather than having people mess about with string overrides. We could just pull the message entirely and have people configure their own with Rules but I don't rate the usability of that for the average Drupal user. With a configurable message the admins have the ability to not show a message if they prefer.

Thoughts?

haydeniv’s picture

Status: Active » Needs review
FileSize
33.68 KB
19.49 KB
4.11 KB

ok. I gave the option to set "No Message" as a status or if they delete the message, no message will show up on logout. Otherwise what you would expect happens with this patch.

Logged out message
Logged out message result

johnennew’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Needs review » Active

Thanks @haydeniv for the patch, just what I meant. I think this is much more user friendly.

I've committed to 7.x-2.x : http://drupalcode.org/project/session_limit.git/commit/af10bc3

Setting to 6.x-2.x for the backport.

haydeniv’s picture

I don't have a 6.x environment so if someone else wants to take on the backport it won't hurt my feelings. :)

johnennew’s picture

Assigned: Unassigned » johnennew

No worries - assigning to me.

johnennew’s picture

Status: Active » Needs review
FileSize
3.49 KB

6.x-2.x patch for review

johnennew’s picture

Status: Needs review » Fixed

Tests pass - committing to 6.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.