Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Right now users can be freaked out by the error level severity of the logged out message making them think they have done something wrong or their account has been compromised. You are able to change the message through string override but you cannot change the message severity. This patch ads that functionality.
Comment | File | Size | Author |
---|---|---|---|
#7 | session_limit-configure_logout_message-2014737-7547021.patch | 3.49 KB | johnennew |
#3 | 2014737-configure-message-severity-3.patch | 4.11 KB | haydeniv |
#3 | session-logout-result.png | 19.49 KB | haydeniv |
#3 | logout-message-admin.png | 33.68 KB | haydeniv |
#1 | 2014737-configure-message-severity-1.patch | 1.97 KB | haydeniv |
Comments
Comment #1
haydeniv CreditAttribution: haydeniv commentedAnd the patch.
Comment #2
johnennew CreditAttribution: johnennew commented@haydeniv, thanks for the patch! Not sure why the testbot has ignored it.
I was wondering if we should just go provide the ability to set the message in the admin screen for session_limit rather than having people mess about with string overrides. We could just pull the message entirely and have people configure their own with Rules but I don't rate the usability of that for the average Drupal user. With a configurable message the admins have the ability to not show a message if they prefer.
Thoughts?
Comment #3
haydeniv CreditAttribution: haydeniv commentedok. I gave the option to set "No Message" as a status or if they delete the message, no message will show up on logout. Otherwise what you would expect happens with this patch.
Comment #4
johnennew CreditAttribution: johnennew commentedThanks @haydeniv for the patch, just what I meant. I think this is much more user friendly.
I've committed to 7.x-2.x : http://drupalcode.org/project/session_limit.git/commit/af10bc3
Setting to 6.x-2.x for the backport.
Comment #5
haydeniv CreditAttribution: haydeniv commentedI don't have a 6.x environment so if someone else wants to take on the backport it won't hurt my feelings. :)
Comment #6
johnennew CreditAttribution: johnennew commentedNo worries - assigning to me.
Comment #7
johnennew CreditAttribution: johnennew commented6.x-2.x patch for review
Comment #8
johnennew CreditAttribution: johnennew commentedTests pass - committing to 6.x-2.x branch.