There is a logical flaw in the way the XMLRPC server checks to see if the request has the correct # of arguments. It's possible this is a dup because it breaks all XMLRPC methods that have parameters, but I didn't see anything when searching.

CommentFileSizeAuthor
#18 1266102-xmlrpc-try-catch.patch1.55 KBmarcingy
#12 services-1266102-9.patch1.17 KBdasRicardo
#9 services-1266102-9.patch1.16 KBdasRicardo
#2 xmlrpc_server_argvalidation_v2.patch1006 bytesst0nerhat
xmlrpc_server_argvalidation.patch1011 bytesst0nerhat
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, xmlrpc_server_argvalidation.patch, failed testing.

st0nerhat’s picture

st0nerhat CreditAttribution: st0nerhat commented
FileSize
xmlrpc_server_argvalidation_v2.patch1006 bytes

Fixed line endings

st0nerhat’s picture

st0nerhat CreditAttribution: st0nerhat commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, xmlrpc_server_argvalidation_v2.patch, failed testing.

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Needs work » Reviewed & tested by the community
marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Reviewed & tested by the community » Needs work

The patch has a style issue shoul be

}
elseif .....
kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented

Fixed in both 7.x and 6.x with formatting issues fixed as well.

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Needs work » Fixed
dasRicardo’s picture

dasRicardo CreditAttribution: dasRicardo commented
Status: Needs work » Fixed
FileSize
services-1266102-9.patch1.16 KB

You make an xmlrpc call (user.login) you get the whole page as response http header error code 500.

I wrote a patch to fix this by a correction of a try { which was at the wrong place.

This patch also contains the changes of #1266378: Checking service call non-optional arguments .

dasRicardo’s picture

dasRicardo CreditAttribution: dasRicardo commented
Status: Fixed » Needs review

Status: Needs review » Needs work

The last submitted patch, services-1266102-9.patch, failed testing.

dasRicardo’s picture

dasRicardo CreditAttribution: dasRicardo commented
Status: Fixed » Needs work
FileSize
services-1266102-9.patch1.17 KB
dasRicardo’s picture

dasRicardo CreditAttribution: dasRicardo commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, services-1266102-9.patch, failed testing.

dasRicardo’s picture

dasRicardo CreditAttribution: dasRicardo commented
Status: Needs work » Needs review

I don't know why the test fails. With eclipse I applied this patch successfully.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Version: 7.x-3.0-rc5 » 7.x-3.x-dev
Status: Needs review » Needs work

The issue was a duplicate of #1266378: Checking service call non-optional arguments , the fix in that issue was committed here http://drupal.org/node/1266102#comment-4984010, please reroll this patch with just the try catch changes and also can you reroll against 7.x.3-dev so as it can be reviewed much mire easily.

Cyberwolf’s picture

Cyberwolf CreditAttribution: Cyberwolf commented

Subscribing.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Title: Logic bug in XMLRPC argument count check » Logic bug in XMLRPC try catch logic
Status: Needs work » Needs review
FileSize
1266102-xmlrpc-try-catch.patch1.55 KB

Reroll with just the try catch element moved

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Needs review » Reviewed & tested by the community

looks good.

kylebrowning’s picture

kylebrowning CreditAttribution: kylebrowning commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.