In Serial Field.module there is use of entitymanager which is deprecated in drupal 8

CommentFileSizeAuthor
#5 entity-2856512-5.patch1.3 KBsolariel
#2 entity-2856512-2.patch1.26 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new entity-2856512-2.patch1.26 KB

Applying the patch, please check

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Good work!

solariel’s picture

solariel commented
Status: Reviewed & tested by the community » Needs work

Patch does not work.
Both getFieldDefinitions() and getFieldMapByFieldType() methods were moved to \Drupal\Core\Entity\EntityFieldManager, not the EntityTypeManager.

Error: Call to undefined method Drupal\Core\Entity\EntityTypeManager::getFieldMapByFieldType() in /var/www/tolkaanvraag/web/modules/contrib/serial/src/SerialSQLStorage.php on line 161 #0 /var/www/tolkaanvraag/web/modules/contrib/serial/serial.install(18): Drupal\serial\SerialSQLStorage->getAllFields()
solariel’s picture

solariel commented
Status: Needs work » Needs review
StatusFileSize
new entity-2856512-5.patch1.3 KB

I've updated the patch, placing for a review.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Thanks

  • colorfield committed d0856b2 on 8.x-1.x 
    Issue #2856512 by Pavan B S, solariel, joelpittet: Removing deprecated...
colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.