First of all thanks for this great module!

Right now it's only possible to define pane separator when using the semantic panels style plugin on regions.

It would be cool to be possible to define html wrapper elements on the regions too.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

osopolar’s picture

Status: Active » Needs review
FileSize
4.91 KB

This ads a container to the region, is this what you requested?

afoster’s picture

Thanks for the patch - but it's a little different then what I was thinking.

I can now edit the separator which is useful, but I would like to control a wrapper for the panel region. The reason I'd like to do this would be to apply grid layouts to the panels inside the region by controlling the css that wraps them. So I'm not putting specific grid classes on each panel pane, but it would be helpful to wrap the region itself.

So by default panels creates something similar to this.

<div class="panel_region">
   <div class="panel_pane><p>some content 1</p></div>
   <div class="panel_pane><p>some content 2</p></div>
</div>

It would be great to be able to customize the panel region like this

<section class="custom-grid-3columns">
   <div class="panel_pane><p>some content 1</p></div>
   <div class="panel_pane><p>some content 2</p></div>
</section>

Which may not be possible, so a second option would look like this

<div class="panel_region">
  <section class="custom-grid-3columns">
     <div class="panel_pane><p>some content 1</p></div>
     <div class="panel_pane><p>some content 2</p></div>
  </section>
</div>

Option 1 is better with less markup-cruft, but option 2 is fine as well. Basically by creating a series of grid class I could then more easily manipulate the layout of panel panes in a region but changing the class of the wrapper

osopolar’s picture

You may check Clean Markup Module which allows to select a wrapper and assign classes to it.

afoster’s picture

Status: Needs review » Closed (fixed)

Thanks - That looks like what I need.

osopolar’s picture

Status: Closed (fixed) » Needs review

But maybe the patch is interesting for someone else, like drupov, who opened the issue?

drupov’s picture

Version: 7.x-1.2 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

@osopolar thank you for the patch. It is what was requested and seems to work properly.