Needs work
Project:
Selectize.js
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Mar 2018 at 13:44 UTC
Updated:
10 Sep 2021 at 15:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
anybodyPS: A composer library / packagist.org library from selectize itself doesn't seem to exist yet. See https://github.com/selectize/selectize.js/issues/1378 for a feature request.
Comment #3
sunFollowed up on https://github.com/selectize/selectize.js/issues/1378
There is https://asset-packagist.org/package/bower-asset/selectize that can be used instead.
Somehow my local composer.json doesn't look like https://cgit.drupalcode.org/selectize/tree/composer.json?h=8.x-1.x – let's see whether this patch applies.
Comment #4
rodrigoaguileraI think adding repositories to the composer.json won't help solve this issue since the composer.json for this module will never be a root composer.json except when you are developing the module itself.
Maybe the maintainer for this module can submit a package to packagist.org with the type: 'drupal-library' so installing this module requires less manual steps.
There is a shim package here https://packagist.org/packages/grimmlink/selectize
but is outdated and doesn't have any type.
Comment #5
sunI think it would be at least an improvement compared to status quo, because most projects probably have the asset-packagist repository anyway already. Therefore, the new requirement would be picked up and installed correctly.
Right now, the requirement cannot be resolved at all, because the repositories definition in the composer.json of drupal/selectize does not bubble up to the root project (by design). I only changed the repositories definition, so that a composer install remains to work within the module folder.
Comment #6
anybodyYes this is a problem of many contrib modules which require external libraries... perhaps a core issue or discussion exists for that?
Comment #7
rodrigoaguileraFor clarification the current situation (HEAD and beta5) is composer.json without dependencies.
https://cgit.drupalcode.org/selectize/tree/composer.json?h=8.x-1.x
I really don't know what repo is the latest patch made against.
So folks without the proper repo will get a non-reachable dependency.
Apart from redoing the patch against the latest HEAD I feel the question is: Do we assume most of the people will have the asset-packagist repo configured?
For reference: I'm trying to make it a standard here
https://github.com/drupal-composer/drupal-project/pull/286
Comment #8
mlncn commentedA very similar version of this (pegged to
0.12.6rather than latest, which is probably a good idea and i think no difference right now anyway) is included in the RTBC patch at #2678916: Add support for entity reference with autocompleteComment #9
pasqualleThe composer.json changes should go into readme or install.txt file as repositories do not work from module composer.json.
https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-f...
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
#3198417: Official support for npm
Comment #10
mlncn commentedIt still doesn't *hurt* to add:
and
in composer.json.
I recommend we do that and then document the Composer merge plugin like Webform does.