Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When using select or other for a custom og:type I get the following error every time I save a node.
Notice: Undefined index: #other_delimiter in select_or_other_element_process() (line 138 of /Users/marcus/hosts/drupal7/sites/all/modules/contrib/select_or_other/select_or_other.module).
Notice: Undefined index: #other_delimiter in select_or_other_element_process() (line 163 of /Users/marcus/hosts/drupal7/sites/all/modules/contrib/select_or_other/select_or_other.module).
Comment | File | Size | Author |
---|---|---|---|
#18 | select_or_other-undefined_index-2086643-18.patch | 639 bytes | lolandese |
| |||
#14 | select_or_other-undefined_index-2086643-14.patch | 950 bytes | bbdata |
#4 | undefined-index-2086643-8585801.patch | 1.23 KB | shahinam |
Comments
Comment #1
marcus178 CreditAttribution: marcus178 commentedAny ideas on this, would be nice to get rid of it.
Comment #2
DamienMcKennaI've not had a chance to test it yet, but I will soon.
Comment #3
shahinam CreditAttribution: shahinam commentedIn widget settings form the other_delimiter form element is commented.
The comment above it says:
So it is obvious it will throw notice, where ever we try to fetch this array key.
Attached is a simple, patch to comment out those lines.
Comment #4
shahinam CreditAttribution: shahinam commentedComment #5
shahinam CreditAttribution: shahinam commentedComment #7
shahinam CreditAttribution: shahinam commentedOops, this is not metatag module issue.
Instead select_or_other has this issue. Assigning to that project.
Comment #8
shahinam CreditAttribution: shahinam commented4: undefined-index-2086643-8585801.patch queued for re-testing.
Comment #9
haydeniv CreditAttribution: haydeniv commentedCommenting out the offending lines doesn't fix the problem, it only hides the symptoms.
Comment #10
shahinam CreditAttribution: shahinam commentedAgreed!
As mentioned in comment, I did this because the form element is commented in select_or_other.field_widget.inc on line 285
Comment #11
jstollerI just updated to Select (or other) 7.x-2.21 and it looks like this bug may have been fixed. Can anyone else confirm this?
Comment #12
legolasboA lot of notices were fixed in 2.21, Let's assume this was one of them.
Comment #14
bbdata CreditAttribution: bbdata commentedI am testing the upgrade of select_or_other to v2.22 on a drupal 7.50 install and found that these two notices still appear when I am on a node create form that has a select field.
I patched it by checking if $element['#other_delimiter'] is empty on line 138 and 163.
Comment #15
bbdata CreditAttribution: bbdata commentedComment #16
pribeh CreditAttribution: pribeh commented@bbdata, I'm getting the same. I've tried your patch but I'm getting:
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 159 with fuzz 1.
Comment #17
legolasboSetting to needs work per the comment in #16
Comment #18
lolandese CreditAttribution: lolandese at HCL Technologies Limited commentedSimpler. Against 7.x-2.x.
Comment #19
daften CreditAttribution: daften at Dropsolid commentedClosing as outdated because no activity in a long time and Drupal 7 goes EOL soon. Feel free to re-open if needed.