Problem/Motivation

While browsing the repository, I noticed a log of config-related code is commented. What's the reason behind this? It seems valuable to me to be able to easily configure Select2, especially since it's applied globally.

Remaining tasks

  • Add more configuration options
  • Create a configuration form
  • Add the possibility to reset the configuration to defaults through the form, in case you mess up the selectors

Issue fork select2_all-3184189

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !2

DieterHolvoet’s picture

DieterHolvoet CreditAttribution: DieterHolvoet at Wieni commented
Assigned: Unassigned » DieterHolvoet
Issue summary: View changes

I started a draft pull request.

trwill’s picture

trwill CreditAttribution: trwill commented

Patch is working great for me! I think we probably would want a page to set these vars besides just providing the ymls but this definitely solved my use case!

richardbporter made their first commit to this issue’s fork.

richardbporter’s picture

richardbporter CreditAttribution: richardbporter at Principal Financial Group commented

I had started working on this separately and then found this issue. Since it hadn't been updated in a while, I pushed some commits to keep it moving.

There are probably more UX improvements, validation and select2 doc references that could be made to the settings form. Test coverage would be good also.

richardbporter’s picture

richardbporter CreditAttribution: richardbporter at Principal Financial Group commented
Assigned: DieterHolvoet » richardbporter
Status: Active » Needs review

It might be good to get an initial review to confirm this is the right direction before going further.