The anchor tag in the .info file has herf instead of href.

<a herf="http://ivaynberg.github.io/select2" target="_blank">Select2</a>

This is also a problem in the select2/translations/ru.po file.

CommentFileSizeAuthor
#9 select2-broken-anchor-tag-3034422-9.patch930 bytessolideogloria
#7 select2-broken-anchor-tag-3034422-7.patch1.67 KBsolideogloria
#5 select2-broken-anchor-tag-3034422-5.patch1.71 KBsolideogloria
#2 select2-broken-anchor-tag-3034422-2.patch992 bytessolideogloria

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
StatusFileSize
new select2-broken-anchor-tag-3034422-2.patch992 bytes
solideogloria’s picture

solideogloria commented
Status: Active » Needs review
solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

Because this issue is remarkably simple and it's in the info file, I am going to mark this as RTBC.

solideogloria’s picture

solideogloria commented
StatusFileSize
new select2-broken-anchor-tag-3034422-5.patch1.71 KB

The URL actually redirects to select2.org now, so changing the links.

laryn’s picture

laryn
he/him
commented
Status: Reviewed & tested by the community » Needs work

@solideogloria The latest patch (with updated URL) reverts the 'herf' issue. :)

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
StatusFileSize
new select2-broken-anchor-tag-3034422-7.patch1.67 KB

Fixed the "herf" issue again. Also removed target="_blank" (deprecated functionality), because the user should be in control.

laryn’s picture

laryn
he/him
commented
Status: Needs review » Needs work

There's another escape needed on a quote mark after the URL in this line:

msgid "Adds integration with the <a href=\"https://select2.org/">Select2</a> Javascript plugin."

Also, when I was working on the Backdrop version I saw a lot of places where front-facing text needed cleanup. Maybe we should not include the change to the description in this issue since it's unrelated, but open a new issue and do a bunch of text cleanup?

solideogloria’s picture

solideogloria commented
Status: Needs work » Needs review
StatusFileSize
new select2-broken-anchor-tag-3034422-9.patch930 bytes

Removed text cleanup and added missing backslash.

laryn’s picture

laryn
he/him
commented
Status: Needs review » Reviewed & tested by the community

LGTM, thanks!

PS - do you want to start a patch in this issue for the textual cleanup?
https://www.drupal.org/project/select2/issues/3145875