CommentFileSizeAuthor
#5 seeds_toolbar_issue_101719.jpg61.47 KBbamberjp
#4 keyboard_accessibility-3065660-4.patch59.19 KByahyaalhamad

Comments

shaal created an issue. See original summary.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Has focus been removed?

Also, do you know how to create a patch @shaal it really helps maintainers review your code. Screenshots are good too.

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented

We should avoid using border since it can be heavy to the eyes. But we can color the text and give it a decoration.

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented
StatusFileSize
new keyboard_accessibility-3065660-4.patch59.19 KB

I'm still not sure how exactly we should do it without impacting the style that much.

bamberjp’s picture

bamberjp commented
Issue summary: View changes
StatusFileSize
new seeds_toolbar_issue_101719.jpg61.47 KB

Tested on Chrome 77.0.3865.120 (Official Build) (64-bit), Firefox 69.0.6 (64-bit) and Microsoft Edge.

Accessibility Issue

The menu does not appear to expand correctly when accessing it via keyboard tab.

yahyaalhamad’s picture

yahyaalhamad
Location Palestine
commented

Indeed, this might be a problem because we use a class when we want a toolbar tray to open, we might just open the toolbar tray when focused, might be better.