Switch from Video Embed Field to Media Library remote video

Not prod ready. This doesn't work in Sector yet. We override the media.settings.yml file unnecessarily (See #3080497: [Meta] Cleanup our config files).

So we need to remove that file.

But we also need to provide an update hook for existing sites. We need to add the

oembed_providers_url: 'https://oembed.com/providers.json'

key & value to media.settings.yml

Hi Daniel,

I have attached the patch as required, I test it on the local site and it works fine for me. please check it again when you apply it. Cheers.

1. +++ b/sector.install
   @@ -43,6 +43,9 @@ function sector_install() {
   +
   +  // Update media.settings.yml
   +  sector_update_8401();
   

   This isn't needed. New sites will already have the new config, and the update will run on existing sites

2. +++ b/sector.install
   @@ -162,3 +165,15 @@ function excludeXmlsitemapNodes() {
   +/**
   + * update media.settings.yml function
   + * Implement Hook_update_N()
   + *
   + * @param [type] $sandbox
   + * @return void
   + */
   

   This should be a bit more descriptive. The param and return also isn't needed in this case.

3. +++ b/sector.install
   @@ -162,3 +165,15 @@ function excludeXmlsitemapNodes() {
   +  $data = ["oembed_providers_url" => "https://oembed.com/providers.json"];
   +  \Drupal::configFactory()->getEditable('media.settings.yml')->setData($data)->save();
   

   This creates a new config entity called media.settings.yml. We want to alter media.settings and add the new key & value to the end.

Hi Daniel,

This is a new patch, I deleted some unnecessary in the code. Please check it out

Thang.

new patch file, deleted some comments.

Here's a mega patch with all changes.

This swaps the sector starter kit over to media library and provides a minor install task to allow older Sector sites to take up the media library if they decide to.

Crediting edmonkey & emma_selley for all their internal testing for this change.

Thanks all!