Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow this issue to track release candidates for 7.x-1.9.
Original issue description:
The only difference between 7.x-1.x-dev and 7.x-1.8 is the 'maxlength' field on all of the -src directives. We have a large site that needs that maxlength, but I don't want to put them on the -dev version of the module if I can avoid it. Since the maxlength change appears to be the only outstanding change from 7.x-1.8, please push a 7.x-1.9 release incorporating this change so that we can avoid using a -dev release. Thanks! Tim
Comments
Comment #1
jweowu CreditAttribution: jweowu commentedSorry, didn't happen.
If you want to run that version, the patch for that change was:
http://drupalcode.org/project/seckit.git/patch/61339ac0db7c05aaaf5b0c71c...
Comment #2
gregglesI don't understand comment #1.
Can you clarify when you think a 7.x-1.9 release will make sense?
Comment #3
jweowu CreditAttribution: jweowu commentedI just meant that a bunch of other changes have happened since that commit, so the suggested release no longer made any sense to me -- but noting that applying that patch to version 1.8 would provide the desired state. (I was forgetting that I could tag any arbitrary commit for release, mind.)
In any case... I feel that #2200187: CSP report Content-Type has changed. is the most notable issue with 1.8, so I'd like to make a 1.9 release on that account. I've committed the patch provided for that, but there's also some un-pushed refactoring I did when that issue was logged, which I intend to revisit and merge.
That will more or less cover the current issues in the queue, so I guess I'll make a release after that (from HEAD, but perhaps tagging as 1.9-rc1, given that the recent changes won't have had a chance to undergo much in the way of testing).
Re-opening this for discussion. Will close after the release.
Any testing appreciated.
Comment #4
gregglesIf you make a 1.9-rc1 then it will not show up on the project page. You can add text to the project page with a link to it and ask people to try it out, but that may not happen enough.
An alternative is to separate the things that make you worried and put them in a 7.x-2.x branch and then make a 7.x-1.9 release of just the things that seem low risk.
Comment #5
jweowu CreditAttribution: jweowu commentedWell that's very annoying, but I'm certainly not making a 7.x-2.x branch for no good reason.
Release candidate is now available: 7.x-1.9-rc1
Please test and report back.
Comment #6
jweowu CreditAttribution: jweowu commentedComment #7
jweowu CreditAttribution: jweowu commentedComment #8
jweowu CreditAttribution: jweowu commentedComment #9
jweowu CreditAttribution: jweowu commentedComment #10
rooby CreditAttribution: rooby commentedIt might be worth putting a link to the rc version on the project page with a little note about 1.9-rc and what's new there and that it needs testing to make a full 1.9 release.
Most people will never see it otherwise.
There is also no patch here for the "Needs review" status.
Comment #11
jweowu CreditAttribution: jweowu commented"Needs review" is the appropriate status; it doesn't only apply to patches.
I did think about putting a note on the project page, but I wasn't convinced that anyone would see that either, as it's not possible to add text in close proximity to the release list itself.
Drush does list 7.x-1.9-rc1 as an available update, so that's helpful at least.
Disappointing not to have any feedback at all on this release candidate after the better part of a month, however. I'll probably have to just go ahead and release it on the basis that no news is good news.
Comment #12
jweowu CreditAttribution: jweowu commentedI've initiated the release of 7.x-1.9, which is identical to 7.x-1.9-rc1.
Comment #13
tkrajcar CreditAttribution: tkrajcar commentedThanks @jweowu!
Comment #14
stefan.r CreditAttribution: stefan.r commentedThanks!