Search API SolrCloud module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#3 search_api_solrcloud_array_search_results.png88.93 KBdhruveshdtripathi
#2 short_array_syntax-2874731-2.patch30.59 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2874731-2.patch30.59 KB
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
search_api_solrcloud_array_search_results.png88.93 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 71 array declarations, after applying patch there are 10. Those 10 arrays are in_arrays and is_arrays.

Good work!

jsteggink’s picture

jsteggink CreditAttribution: jsteggink as a volunteer and at knowsy commented

Thanks all! I will change this soon with a big refactoring update.

jsteggink’s picture

jsteggink CreditAttribution: jsteggink as a volunteer and at knowsy commented
Assigned: Unassigned » jsteggink
jsteggink’s picture

jsteggink CreditAttribution: jsteggink as a volunteer and at knowsy commented
Status: Reviewed & tested by the community » Fixed
jsteggink’s picture

jsteggink CreditAttribution: jsteggink as a volunteer and at knowsy commented
Status: Fixed » Closed (fixed)