\Drupal\search_api_solr\Solr\SolrHelper tries to preg_match on \Solarium\QueryType\Select\Query\FilterQuery. We need to pass getQuery so it has a string.

CommentFileSizeAuthor
#6 warning_preg_match_-2776083-6.patch995 bytesmglaman
#2 warning_preg_match_-2776083-2.patch807 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented
Status: Active » Needs review
FileSize
warning_preg_match_-2776083-2.patch807 bytes

This removes the error and passes "FIELD:VALUE" to preg_match.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH for OSCE: Organization for Security and Co-operation in Europe commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thanks for the patch!
As pointed out in https://www.drupal.org/node/2744733#comment-11366957 we don't have any test coverage for location / spatial searches at all. That has to be changed.
What do you think? Can you provide some test code, potentially based on https://www.drupal.org/node/2744733#comment-11454099 ?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer commented

Yeah, I'll give it a shot. I'm working on a personal product, and I'll need the test coverage. Might be next weekend, however.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH for OSCE: Organization for Security and Co-operation in Europe commented

That would be great!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman as a volunteer and at Centarro commented
FileSize
warning_preg_match_-2776083-6.patch995 bytes

Haven't had time for testing. But re-rolling because patch fails. Again, filter query does not have a __toString method so we need to manually invoke this method.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner at bio.logis Genetic Information Management GmbH for OSCE: Organization for Security and Co-operation in Europe commented
Status: Needs work » Closed (duplicate)
Issue tags: -Needs tests
Related issues: +#2744733: Add location as a supported DataType for SearchApiSolrBackend

It seems like the patch is already included in the latest patch for #2744733: Add location as a supported DataType for SearchApiSolrBackend. That's the patch that will be committed as soon there's some test coverage.
Please got ahead in that single issue. Thanks for reporting!