This is to fix one obvious PHP 7.3 compatibility issue with the module:

"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? search_api.module:1479

CommentFileSizeAuthor
#2 3009744-2-php-7.3-compatibility.patch368 bytesevgeny.chernyavskiy

Comments

evgeny.chernyavskiy created an issue. See original summary.

evgeny.chernyavskiy’s picture

evgeny.chernyavskiy commented
StatusFileSize
new 3009744-2-php-7.3-compatibility.patch368 bytes
evgeny.chernyavskiy’s picture

evgeny.chernyavskiy commented
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: evgeny.chernyavskiy » Unassigned

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Ah, alright, thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colinstillwell’s picture

colinstillwell commented

During our analysis for the PHP 7.3 compatibility warning fixes, we have been replacing anything with "continue" to "break" so that it preserves existing behaviour, without outputting warnings.

The patch in this issue actually changes the behaviour, so we should be careful not to get confused with this.

Having had a look at the change, we believe that the patch in https://www.drupal.org/node/3032431 may actually make more sense?

I just wanted to share our findings for the community!

evgeny.chernyavskiy’s picture

evgeny.chernyavskiy commented

@colinstillwell, my understanding is that we do need to continue 2; in the default case of a switch there to avoid adding $task->id to executed tasks.