Closed (fixed)
Project:
Search API
Version:
7.x-1.x-dev
Component:
General code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2018 at 16:30 UTC
Updated:
19 Apr 2018 at 08:04 UTC
Jump to comment: Most recent
Comments
Comment #2
jcnventuraNot fixed by #2902963: "Bad request" error with nested queries containing tags.
Comment #3
jcnventuraComment #4
jcnventuraReverting #2566529: Add a "Content access" processor for "Multiple types" indexes fixed the issue.
Comment #5
jcnventuraJust FYI, my index is not multi-entity. It's multi-bundle on 4 different content types of the 'node' type.
This makes it a "SearchApiEntityDataSourceController", and not the "SearchApiCombinedEntityDataSourceController", which the patch #2566529 was intended to address.
Furthermore, the condition will attempt to see if 'node:status' is 1, but no field is ever inserted with this name. If I add status as a fulltext field, it will get added as 'status', and that does prevent the exception during the filter creation, but it still doesn't return any results.
Comment #6
jcnventuraThe only reason that admin can use the search page is because it has the 'bypass node access' permission and that enables it to bypass all of the code in _search_api_query_add_node_access().
Comment #7
jelle_sWe had the same issue, had to revert to search api 1.22
Comment #8
akolahi commentedOur users are reporting the same issue as well.
Comment #10
drunken monkeyThanks a lot for noticing and reporting this!
Indeed, the patch in the other issue looks just aweful, on closer inspection. I'm very sorry for letting that slip past me!
I've now reverted that patch and created a new release right away: 7.x-1.24. This should fix the problems, as you said. It will be up to the people who wanted that feature to come up with a proper patch for it.
If you want to help avoid such problems in the future, you can try out dev releases of this module now and again. That would help make sure that no such obvious problems are present in stable releases. Apparently this buggy patch has been in the dev release for more than three months without anyone noticing.
Or, even better, help by reviewing/testing patches proposed patches now and again. (But I of course know it's hardly possible to do that for all the modules one uses.)
In any case, I of course should also take more care reviewing patches. Seems I've become lenient lately regarding patches in D7, since few people ever seem to care anyways, so I'm reluctant to go back and forth numerous times with a new patch, or review/test it in detail.
So, again, my apologies! I'll try to be more careful again in the future.
And thanks again for reporting this!
Comment #11
jcnventuraThanks @drunken monkey!