There are methods still called validate() in some of the forms.
According to change record EntityFormInterface::validate() removed in favor of EntityFormInterface::validateForm() they need to be renamed.
If they are not renamed, they aren't called. This breaks IndexForm which requires validateForm to create a $this->originalEntity before submitForm for a new index.
Without the patch that leads into a fatal error.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2529036-formValidate-05.patch | 2.29 KB | mkalkbrenner |
| #5 | 1-5-interdiff.txt | 508 bytes | mkalkbrenner |
| #1 | 2529036-01-form_validate_to_formValidate.patch | 1.75 KB | ekes |
Comments
Comment #1
ekes commentedCleans up a set of test fails I had.
Comment #2
mkalkbrennerPriority is 'Critical' because it leads to a fatal error when creating a new index:
Fatal error: Call to a member function getOptions() on a non-object ...BTW: The corresponding change record is EntityFormInterface::validate() removed in favor of EntityFormInterface::validateForm()
Comment #4
ekes commentedNB: The exception that this fails on is there without this patch. It's something separate.
Comment #5
mkalkbrennerJust a minor addition. IndexProcessorsForm::validateForm() should also delegate to parent::validateForm().
Comment #7
ekes commentedSee #2529990: Call to Renderer::render() causing an exception. for a patch that makes that exception go away.
Comment #9
drunken monkeyThanks a lot to both of you, looks good. Committed.
In the future, if Core breaks our module, please feel free to ping me in IRC or via mail to commit the patch.
In any case, thanks again!