Replace all usages of deprecated EntityManager [#2867272]

EntityManager has been split into 11 classes (more info). So now EntityManager and EntityManager are deprecated.

Comment	File	Size	Author
#7	scheduler-replace_entitymanager-2867272-7.patch	5.95 KB	idebr
#7	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 34 pass
#7	interdiff-6-7.txt	1.05 KB	idebr
#6	scheduler-replace_entitymanager-2867272-6.patch	5.93 KB	idebr
#6	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 34 pass
#6	interdiff-4-6.txt	1.72 KB	idebr
#4	interdiff.txt	441 bytes	Pavan B S
#4	2867272-4.patch	3.99 KB	Pavan B S
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail
#2	2867272-2.patch	4.61 KB	Pavan B S
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

6 April 2017 at 06:43

Pavan B S created an issue. See original summary.

Comment #2

Pavan B S CreditAttribution: Pavan B S at Valuebound commented 6 April 2017 at 06:45

Assigned:	Pavan B S	» Unassigned
Status:	Active	» Needs review

File	Size
2867272-2.patch	4.61 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail

Applying the patch, please review.

Comment #3

6 April 2017 at 06:48

Status:

Needs review

» Needs work

The last submitted patch, 2: 2867272-2.patch, failed testing.

Comment #4

Pavan B S CreditAttribution: Pavan B S at Valuebound commented 6 April 2017 at 09:03

Status:

Needs work

» Needs review

File	Size
2867272-4.patch	3.99 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail
interdiff.txt	441 bytes

Applying the patch, please review.

Comment #5

6 April 2017 at 09:08

Status:

Needs review

» Needs work

The last submitted patch, 4: 2867272-4.patch, failed testing.

Comment #6

idebr CreditAttribution: idebr at ezCompany commented 25 May 2018 at 13:23

Status:

Needs work

» Needs review

File	Size
interdiff-4-6.txt	1.72 KB
scheduler-replace_entitymanager-2867272-6.patch	5.93 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 34 pass

3 files were hidden/shown/deleted

File	Size
2867272-2.patch	4.61 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail
2867272-4.patch	3.99 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 4 pass, 30 fail
interdiff.txt	441 bytes

This should fix the test failures and remove the remaining usages of the deprecated entity manager.

Comment #7

idebr CreditAttribution: idebr at ezCompany commented 25 May 2018 at 13:37

File	Size
interdiff-6-7.txt	1.05 KB
scheduler-replace_entitymanager-2867272-7.patch	5.95 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 34 pass

2 files were hidden/shown/deleted

File	Size
interdiff-4-6.txt	1.72 KB
scheduler-replace_entitymanager-2867272-6.patch	5.93 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 34 pass

The dependency injection should cast its dependency as an interface. This fixes problems like #2708957: SchedulerManager throws exception on receiving EntityManagerWrapper from web profiler

Comment #8

idebr CreditAttribution: idebr at ezCompany commented 7 June 2018 at 14:27

Note this patch has been included in #2867272: Replace all usages of deprecated EntityManager, so it might become outdated if the related issue is resolved.

Comment #9

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented 7 June 2018 at 15:51

+#2868553: Fix the code to adhere to Drupal Best Practice

Thanks for the info. However, you pasted the wrong issue number. You have linked this issue with itself. (would be good if that could be a validation check on the submission form).

I think you meant to link to your work on #2868553: Fix the code to adhere to Drupal Best Practice instead.