After I have added an external css is thrown this notice:

Notice: Undefined index: extension in sasson_css_alter() (line 35 of /home/jean-louis/www/allacortedelleterme.localdev/public_html/sites/all/themes/sasson/template.php).

CommentFileSizeAuthor
#3 template.php_.txt320 bytesrobertom
#1 sasson-external_css_thrown_notice-1431432-01.patch788 bytesrobertom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Active » Needs review
FileSize
sasson-external_css_thrown_notice-1431432-01.patch788 bytes

I would add a proposed patch

konforti’s picture

konforti CreditAttribution: konforti commented
Status: Needs review » Postponed (maintainer needs more info)

Thanks @robertom.
Although your patch looks good and it's making sense to put those lines in the IF statement, cause we dealing only with files anyway,
I still don't see why you getting this error.
I couldn't reproduce this error in my tests, and I want to be sure we covers all cases.
Can you please provide the CSS path you using and the way you add it to your site?

Thanks.

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
template.php_.txt320 bytes

Oh yes, sorry if I haven't added my file before... (and sorry for my bad english)

konforti’s picture

konforti CreditAttribution: konforti commented
Status: Needs review » Closed (fixed)

Commited
http://drupalcode.org/project/sasson.git/commit/refs/heads/7.x-2.x

Thanks !

  • Commit 37d3661 on 7.x-2.x, 7.x-3.x, PHPSass, 7.x-3.x-Assetic, 7.x-3.x-susy authored by robertom, committed by konforti: 
    issue #1431432 by robertom: Fixing handling external css files