Problem/Motivation

I've been running into an issue where salesforce_mapped_object.vid references a non-existent version id, ie. doesn't match any entry in salesforce_mapped_object_revision.vid

This causes all sorts of problems:
- During pull, the entity creation succeeds, but writing the mapped object fails. This leads to infinite duplicate creation.
- The mapped object fails to load, so from the UI entities appear to be unmapped.
- Others

I'm relatively sure this has to do with the revisions limit and the pruning mechanism. So maybe that needs to be looked at and revised. Maybe also an artifact of however Pantheon implements databases.

Steps to reproduce

I have not been able to reliably reproduce yet.

Proposed resolution

Ideas:

  • Get rid of revisions
  • Use the storage handler post-save to make sure revisions match between base and revisions table.
  • Similar, but use cron to do it.
  • Identify root cause and fix it.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork salesforce-3593771

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

aaronbauman created an issue. See original summary.

aaronbauman’s picture

Issue summary: View changes

aaronbauman’s picture

Status: Active » Needs review
aaronbauman’s picture

Here's a patch version that will apply to 5.x

aaronbauman’s picture

StatusFileSize
new6.41 KB

Updated patch for 5.x

aaronbauman’s picture

StatusFileSize
new14.13 KB

ugh, messed up the patch.

aaronbauman’s picture

StatusFileSize
new14.52 KB

3rd time's a charm on the patch

aaronbauman’s picture

Actually don't use those patches.
The MR works on both 6.x and 5.x branches.

  • aaronbauman committed 371bc87b on 5.1.x
    Issue #3593771 - Move the prune revision mechanism from MappedObject...

  • aaronbauman committed c6e829f7 on 6.0.x
    Issue #3593771 - Move the prune revision mechanism from MappedObject...