Problem/Motivation

If I enable salesforce but no other modules and then visit admin/help/salesforce, I will get the error: RouteNotFoundException: Route "salesforce.oauth_callback" does not exist.

Proposed resolution

Make the help page check for salesforce.oauth_callback route before using it.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork salesforce-3588345

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !124

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 5.1.x-dev » 6.0.x-dev

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

This route no longer exists, so we can purge it.

Further, this callback is ignored by JWT auth.

Updated in latest dev.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.0.x-dev » 5.1.x-dev
Status: Fixed » Active

Sorry, I made a mistake rebasing on 6.0.x. The route is still in 5.1.x, but may not exist because it is part of salesforce_oauth, which might not be installed. My original change should be made to 5.1.x.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review

I have adjusted the merge request to make the needed fix to 5.1.x.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Reviewed & tested by the community

LGTM, thanks