ExpressionManager needs an interface, all usages should type-hint to the interface only.

Comments

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Issue tags: +Contributor
p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented
Assigned: Unassigned » p4trizio
Category: Bug report » Task

working on this, just made a pull request on github: https://github.com/fago/rules/pull/143

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Active » Needs review

Thanks, you should set thinkgs to needs review once they are ready.

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Fixed

Thanks, there were just some minor documentation glitches in the interface - I fixed them and merged your changes.!

p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented

I'm happy to read this, thank you!

  • 3c380ac committed on 8.x-3.x 
    Issue #2453535 by p4trizio: Add an interface the ExpressionPluginManager...
  • bb46a65 committed on 8.x-3.x
    Issue #2453535: Fixed minor documentation glitches in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.