RulesState should have an interface.

Comments

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Issue tags: +Contributor
p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented
Assigned: Unassigned » p4trizio
Category: Bug report » Task
p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented
Status: Active » Needs review

pull requested: https://github.com/fago/rules/pull/148

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Needs work

Thanks. Your PR includes the expression manager changes also - it's better to separate changes if possible, so we can merge them separately. Could you rebase your branch on the latest 8.x-3.x?

p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented

ok got it, sorry for inexperience, i'll do as soon as I can thanks

p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented

new pull request: https://github.com/fago/rules/pull/149

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Status: Needs work » Needs review
dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
CreditAttribution: dasjo commented
Issue tags: +drupaldevdays
fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Needs work

added a few comments to the PR

p4trizio’s picture

p4trizio CreditAttribution: p4trizio commented

new pull request: https://github.com/fago/rules/pull/168

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs work » Fixed

Committed, thanks!

  • klausi committed d94d2a7 on 8.x-3.x authored by p4trizio 
    Issue #2453533 by p4trizio: Rules state does not have an interface

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.