As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#9 roleassign-2766347-9.patch2.77 KBDane Powell
#5 interdiff-2766347-2-3.txt477 bytesVinay15
#5 2766347-5.patch2.16 KBVinay15
#2 2766347-2.patch2.18 KBVinay15
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Vinay15 created an issue. See original summary.

Vinay15’s picture

Vinay15
he/him
Primary language Marathi
Location Navi Mumbai
CreditAttribution: Vinay15 at Blisstering Solutions commented
Assigned: Vinay15 » Unassigned
Status: Active » Needs review
FileSize
2766347-2.patch2.18 KB

Removed @file docblock.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented 
+++ b/src/ProxyClass/RoleAssignUninstallValidator.php
@@ -1,14 +1,5 @@
-/**
- * This file was generated via php core/scripts/generate-proxy-class.php 'Drupal\roleassign\RoleAssignUninstallValidator' "modules/roleassign/src".
- */
-

These lines are present in many core files and should not be removed. Also, the core files have 

// @codingStandardsIgnoreFile

on the second line of those files, so please put it there.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Needs work
Vinay15’s picture

Vinay15
he/him
Primary language Marathi
Location Navi Mumbai
CreditAttribution: Vinay15 at Blisstering Solutions commented
Status: Needs work » Needs review
FileSize
2766347-5.patch2.16 KB
interdiff-2766347-2-3.txt477 bytes

Updated the changes.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Thanks!

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented

Looks good, can we get this merged?

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2766347-5.patch, failed testing.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Status: Needs work » Needs review
FileSize
roleassign-2766347-9.patch2.77 KB

Re-roll of #5

  • salvis committed 7509a05 on 8.x-1.x 
    Issue #2766347 by Vinay15, Dane Powell: Remove @file tag docblock from...
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Fixed

Thank you, Vinay15 and Dane Powell!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.