Add a new configurable email notification system

This would be a new feature: new events should be created and dispatched on the right moment. Check out the current RoleExpiresEvent to find an example (it's dispatched inside role_expire_cron function). I also recommend you to check out Rules module source code.

First thank you for your work, definitely this feature would be handy and is almost expected to be on this module. Warning messages like one month, 10 days, 5 days and on expiry day (days to be configurable) should be an integral feature of this module IMO. Use cases like in subscriptions, this will be a required functionality.

If I could I would have submitted a patch.

Hello all,
I need this feature and agree, that it can be placed here, so I've implemented it as separate sub-module. For main module I've only updated event class and cron function to react on expiration event. For notification event I've implemented similar, but separate event. Both events are processed by one subscriber, which sends actual emails. There is also cron function in new module to dispatch new type of events. Notifications are managed on `admin/config/people/role-expire/notification` page. Each notification has email body and subject, checkboxes for possible roles, assigned to this notification and field for number of days before expiration date when notification should be sent. In order to prevent sending same notification several times, I use `user.data` service and keep information there.

TypeError : Argument 1 passed to Egulias\EmailValidator\EmailValidator::isValid() must be of the type string, null given
change
$message['headers']['Sender'] = \Drupal::config('system.site')->get('mail');

The last patch have the issue that send the email notification always in default website language. This patch let to send the current language.

This patch fixes a problem to load the configuration.

Sorry, forget the patch 12.

Actual functionality here works very well. No concerns with that. My nits are mainly about making this a better solution. The main one being around naming, which I recognize is a hard thing. Bumping back to NW.

1. +++ b/modules/role_expire_notification/config/schema/role_expire_notification.schema.yml
   @@ -0,0 +1,32 @@
   +    role_expire_notification_points:
   

   Calling this a notification point doesn't make as much sense as calling it a notification method. Let's rename this here and elsewhere.

2. +++ b/modules/role_expire_notification/role_expire_notification.info.yml
   @@ -0,0 +1,8 @@
   +core_version_requirement: ^8.8 || ^9
   

   Let's change this to also include Drupal 10.

Here's a fix for #15, along with a test of the new module. It also fixes several D10 incompatible issues. Mainly event dispatcher stuffs. It would be nice to have tests setup again as automated tests aren't executing right now.

@heddn I enabled testing.

9.5 and 10.1.x both passed green.

Re-rolled for 2.x. It was a trivial re-roll and the diff stats are identical.

And here's a 3.x patch.

@heddn none of your patches applies on Drupal 9. I am using Drupal 9.5.10.

@heddn @chike The patch cleanly applies to 3.x but this patch has to be split:

1. Test fixes: See #3378674: Fix failing tests
2. New feature without test fixes

Once ready, this feature will only be committed to 3.x branch.

Removed changes that overlap with #3378674: Fix failing tests

any movement on this? it would be great to have this feature enabled or this module integrated with ECA for more power handling

Once drupal 11 version is released (new 4.x branch), a new MR should be created from current patch.

Added latest patch to a new issue fork and created a MR which targets 4.x branch. Please, don't upload more patches, just use the new issue fork.

There are only a few tasks left. Thanks for your contributions!

#3362875: Provide ECA integration would also be a good and more flexible alternative maybe?

@anybody I think both can live together. This feature it's already implemented, we should not force users to install additional modules if not necessary.

any movement on this? Would really be helpful to have email notifications

@elvin - albania drupal developer If you want to use it now you can patch the module via composer patching. It's fully working and it's multilingual. As you can see in the description and recent commits/messages, a lot of work has been done since your previous comment.

Thank you! Testing it right now and will report on anything i may find!

Thank you! Testing it right now and will report on anything i may find!

I’ve reviewed the changes in this task to better understand how the feature is intended to work and what adjustments might be beneficial. Based on this, I have several suggestions:

1. The module allows configuring an email notification for one or more roles, but it does not provide an option to set a default notification for all roles. This means administrators must always check whether every role is explicitly selected. To improve this, we could either introduce a setting that controls a default notification for all roles or add fallback behavior to the roles selection list—for example, if no role is selected, the rule would automatically apply to all roles. What do you think?

2. The notification subforms are currently wrapped in a tag. If a site uses many notifications, this could make the page harder to navigate. Replacing the with might make the interface more manageable.

3. The notification subforms currently use auto-generated titles such as “Method #1.” It would be more intuitive to generate titles based on the roles to which the notification applies, or alternatively, provide a field that lets administrators define their own titles. This would make configurations easier to distinguish.

Please let me know what you think about the described changes, and I'll be ready to finish the issue.