I use this theme function theme_role_delegation_delegate_roles_action_form(). It displays all roles even if user haven't access to delegate some role. We should add appropriate check for this.

Patch is attached.

CommentFileSizeAuthor
role_delegation-role_delegation_form_ignore_permissions.patch1.24 KBalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alan-ps created an issue. See original summary.

Samfall’s picture

Samfall CreditAttribution: Samfall commented

Thank you for this patch. I was very surprised when I noticed this same issue and was going to fix it myself before I checked here.

NWOM’s picture

NWOM CreditAttribution: NWOM commented
Status: Needs review » Reviewed & tested by the community

Applies cleanly and works great. Thank you!

mforbes’s picture

mforbes CreditAttribution: mforbes commented
Status: Reviewed & tested by the community » Needs review

This patch seems identical to the one at https://www.drupal.org/project/role_delegation/issues/2051669 which is older, so it seems like this should be closed as duplicate. Setting to "Needs review" in the meantime in case there is something I'm missing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Closed (duplicate)
Related issues: +#2051669: Views Bulk Operations action lists all roles, not just roles current user can assign