"preg_match() expects parameter 2 to be string" error when user role is changed

I'm unable to recreate this behavior so I'll need you to give me more information.

You say "I just installed role_change_notify": Does that mean you installed it and then configured notifications for some roles? Which roles?

What technique are you using for updating the user's role? going to their /user page?

Have you configured any triggers or actions?

What other modules are installed, please. Especially, do you have token and trigger installed?

I always appreciate bug reports as they make the module better, but I just need some more info on this one.

Thanks,
-Randy

Would love to help with this but haven't had a response.

This may have been improved by #736086: Cannot use object of type stdClass as array, Remove extra hook invocation, so if you're still interested in this, please test with the next dev version.

From what I can gather this happens role_change_notify_token_values() when an empty profile value is sent to check_plain.

I haven't tried (or even looked at) the dev version mentioned in #3 but this patch fixes this issue.

It looks like the patch doesn't apply, but you've provided the magic answer. Thanks very much! If you want to reroll the patch against current dev, that's fantastic, but at least you've given the clue of how to recreate this. Thanks.

Silly me. Here's a patch against dev.

@fp, sorry so slow to respond.

Your patch

+++ role_change_notify.module	24 Mar 2010 05:49:57 -0000
@@ -348,7 +348,7 @@ function role_change_notify_token_values
-        if(strpos($key, 'profile_') === 0) {
+        if(strpos($key, 'profile_') === 0 && $user->key != '') {
           $tokens[$key] = check_plain($account->$key);

It's $account, not $user, and $account->$key, not $user->key. This construct will just prevent profile tokens from ever being used (and also remove the warnings you got)

Attached is what I think you meant. Could you try it and report back?

This problem does not exist in D7 role_change_notify, because the profile field tokens have been removed.

Powered by Dreditor.

Looks good. Thank you.

Committed to HEAD: http://drupal.org/cvs?commit=366452

Thanks so much, fp, deejmer.

@deejmer, it would be great for you to test the dev release and see if this resolves your issue.