This role does exactly what I want except it doesn't offer a configurable permission level with which to work. I have users for which I want them to have permissions to access the settings on this module (as they are able to create users and assign roles), but don't have 'administer site configuration' permissions. It would be nice if you could give the admin page it's own permission setting, thereby allowing this module to have it's permissions set explicitly instead of doubling up on another module's permission set.

I created a patch that I am attaching to this post. If you could apply it for the next release I'd be appreciate.

CommentFileSizeAuthor
role_change_notify_perm.patch14.76 KBJaypan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Active » Needs work

When you submit a patch, please set the status to "needs review". I didn't even notice that you had added a patch to this until just now.

However, something is wrong with this patch - it isn't properly generated. You only need to add role_change_notify_perm and then change the one or two lines that use permissions, right? And this changes vast swaths of the file.

Thanks for helping! It's always great when somebody rolls a patch instead of just asking for something.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Needs work » Fixed

I added the new permission in http://drupal.org/cvs?commit=297552

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.