Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 rip.1.1.2.rector.patch402 bytesproject update bot

Issue fork rip-3434257

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new402 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

olmyr’s picture

Assigned: Unassigned » olmyr
Issue summary: View changes

olmyr changed the visibility of the branch project-update-bot-only to hidden.

olmyr changed the visibility of the branch 3434257-automated-drupal-11 to hidden.

olmyr’s picture

Assigned: olmyr » Unassigned
anybody’s picture

Priority: Normal » Major

Drupal 11 is out

anybody’s picture

Version: 1.1.2 » 1.1.x-dev

Let's add a generic test and see if it's green!

simonbaese’s picture

This module may not be relevant for Drupal 11. I'm not sure if we should bump this. Can you give your opinion?

anybody’s picture

This module may not be relevant for Drupal 11. I'm not sure if we should bump this. Can you give your opinion?

Well I just had a case where I needed it in D11, why don't you think it's relevant? I think there can still be orphaned permissions?

simonbaese’s picture

The module addresses an issue in the upgrade path from Drupal 9 to Drupal 10. Is it possible to upgrade directly from 9 to 11?

grevil’s picture

@simonbaese, @Anybody and I require this module for Drupal 11, as we just finished a Drupal 7 to Drupal 11 migration, where this issue can happen as well.

So it is indeed still relevant!

grevil’s picture

Status: Needs review » Needs work

Back to needs work, based on the GitLab comment.

anybody’s picture

The module addresses an issue in the upgrade path from Drupal 9 to Drupal 10. Is it possible to upgrade directly from 9 to 11?

Yeah that's the main purpose, but we had other cases where it is helpful to be able to remove orphaned permissions, for example the field permission module may create such cases. Same can happen for migrations from Drupal 6 or 7.

simonbaese’s picture

I see. I have no problem with shipping these changes.

grevil’s picture

Status: Needs work » Needs review

Alright. Adjusted accordingly. I removed the hard pipeline failure for phpcs and phpstan, but I can revert that change again, if you disagree and want them to make the pipeline fail.

anybody’s picture

Status: Needs review » Reviewed & tested by the community

No I think that's a very good idea. phpcs and phpstan can be solved in a separate issue. Thank you!

  • simonbaese committed d7e6169f on 1.1.x authored by olmyr
    Issue #3434257 by olmyr, simonbaese, anybody, grevil: Automated Drupal...
simonbaese’s picture

Status: Reviewed & tested by the community » Fixed
anybody’s picture

Thank you very very much @simonbaese! :)

grevil’s picture

Great stuff @simonbaese! Thanks for the superfast reply / fix! 🎉

simonbaese’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.