Getting Error "Error: Call to a member function id() on string in Drupal\reviews\Access\LeaveReviewAccessCheck->access() (line 53 of modules\contrib\reviews\src\Access\LeaveReviewAccessCheck.php)." [#3194498]

Problem/Motivation

Steps to reproduce

Click on add review on node page.

Proposed resolution

Created fix for this

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#3	review-error-fix.patch	1022 bytes	someshver
	review-error-fix.patch	726 bytes	someshver

Issue fork reviews-3194498

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3194498-getting-error-error changes, plain diff MR !1
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

25 January 2021 at 07:26

someshver created an issue. See original summary.

Comment #2

25 January 2021 at 07:26

someshver opened merge request !1

Comment #3

someshver CreditAttribution: someshver as a volunteer and commented 25 January 2021 at 07:33

File	Size
review-error-fix.patch	1022 bytes

1 file was hidden/shown/deleted

File	Size
review-error-fix.patch	726 bytes

Comment #4

jay.lee.bio CreditAttribution: jay.lee.bio commented 13 February 2021 at 04:41

Here are my results after testing a fresh install of Drupal & Reviews:

1) Drupal 8.9.13 & Reviews 1.0.0-beta1 - I get the exact error above.

2) Drupal 8.9.13 & Reviews 1.0.x-dev (which includes the #3 patch above) - I get the following error message:

Error: Object of class Drupal\node\Entity\Node could not be converted to string in Drupal\Core\Entity\EntityStorageBase->buildCacheId() (line 131 of core\lib\Drupal\Core\Entity\EntityStorageBase.php)

3) Drupal 9.1.4 & Reviews 1.0.0-beta1 - I get the exact error above.

4) Drupal 9.1.4 & Reviews 1.0.x-dev (which includes the #3 patch above) - I get the following error message:

Error: Object of class Drupal\node\Entity\Node could not be converted to string in Drupal\Core\Entity\EntityStorageBase->buildCacheId() (line 126 of core\lib\Drupal\Core\Entity\EntityStorageBase.php)

What am I doing wrong?

Comment #5

30 August 2021 at 15:26

scot.hubbard committed 5cd5d57 on 1.0.x

Issue #3194498: Added checked to ensure we are dealing with a node...

Comment #6

scot.hubbard CreditAttribution: scot.hubbard commented 30 August 2021 at 15:31

Status:

Active

» Fixed

Comment #7

13 September 2021 at 15:34

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #8

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 22 November 2023 at 10:32

Issue tags:

-error, -node, -Drupal 8, -Module review

Getting Error "Error: Call to a member function id() on string in Drupal\reviews\Access\LeaveReviewAccessCheck->access() (line 53 of modules\contrib\reviews\src\Access\LeaveReviewAccessCheck.php)."