The message

Note: Leaving all formats unchecked will enable all of them, while leaving all authentication providers unchecked will default to cookie

does not match the behavior.

We could check all on default and add behavior on the methods.

Views Rest export display claims the same but works.

Request formats that will be allowed in responses. If none are selected all formats will be allowed.

CommentFileSizeAuthor
#6 2575453-6.patch8.41 KBandypost
#6 interdiff.txt520 bytesandypost
#4 2575453-4.patch7.9 KBandypost
#4 interdiff.txt7.33 KBandypost
#2 2575453-2.patch3.25 KBandypost
Frontpage__Content____Drupal_8_Development.png26.63 KBclemens.tolboom
Drupal_8_Development.png48.17 KBclemens.tolboom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

clemens.tolboom created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
2575453-2.patch3.25 KB

Makes sense, initial stub on that

EDIT patch on top of #2456283-16: AuthenticationManager::getSortedProviders is protected

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2228141: Add authentication support to REST views
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2730497: REST Views override existing REST routes, +#2308745: Remove rest.settings.yml, use rest_resource config entities
FileSize
interdiff.txt7.33 KB
2575453-4.patch7.9 KB

IS is wrong because \Drupal\rest\Routing\ResourceRoutes::alterRoutes()

So here's a clean-up and bugfix when no method selected

Status: Needs review » Needs work

The last submitted patch, 4: 2575453-4.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs work » Needs review
FileSize
interdiff.txt520 bytes
2575453-6.patch8.41 KB

Fixed test

  • juampynr committed 9cabd12 on 8.x-1.x authored by andypost 
    Issue #2575453 by andypost, clemens.tolboom: Remove message claiming...
juampynr’s picture

juampynr CreditAttribution: juampynr at Lullabot commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.